linux-kernel - Re: [PATCH 1/3] Fix updating of named attribute groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AE9C1A3.8090809@suse.de>
Date:	Thu, 29 Oct 2009 17:24:03 +0100
From:	Tejun Heo <teheo@...e.de>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/3] Fix updating of named attribute groups

Hello,

Matthew Wilcox wrote:
>>> +	} else {
>>> +		sd = sysfs_get(kobj->sd);
>>> +	}
>> nitpick: the last braces aren't necessary.
> 
> But are more aesthetically pleasing.

Hmmm... indeed, CodingStyle says

  Do not unnecessarily use braces where a single statement will do.

  if (condition)
	  action();

  This does not apply if one branch of a conditional statement is a single
  statement. Use braces in both branches.

  if (condition) {
	  do_this();
	  do_that();
  } else {
	  otherwise();
  }

So, please ignore my previous nitpick.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/