linux-kernel - Re: [PATCH 03/16] trivial: fix assorted "through" typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8bf37780910310322h32fd4b4anb5424dd22099c1f4@mail.gmail.com>
Date:	Sat, 31 Oct 2009 08:22:44 -0200
From:	André Goddard Rosa <andre.goddard@...il.com>
To:	Nigel Cunningham <ncunningham@...a.org.au>
Cc:	trivial@...nel.org, linux list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/16] trivial: fix assorted "through" typos

On Sat, Oct 31, 2009 at 8:17 AM, Nigel Cunningham
<ncunningham@...a.org.au> wrote:
> I've only looked at this one, but something caught my eye...
>
> André Goddard Rosa wrote:
>> diff --git a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> index f7b9cdc..b52c1f8 100644
>> --- a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> +++ b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> @@ -38,7 +38,7 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
>>
>>  #ifdef CONFIG_BFIN_EXTMEM_DCACHEABLE
>>       d_cache = CPLB_L1_CHBL;
>> -#ifdef CONFIG_BFIN_EXTMEM_WRITETROUGH
>> +#ifdef CONFIG_BFIN_EXTMEM_WRITETHROUGH
>>       d_cache |= CPLB_L1_AOW | CPLB_WT;
>>  #endif
>>  #endif
>
> "Surely that can't be the only time?", I thought. But it is - all of the
> other #ifdefs are spelled correctly, so you're probably fixing a
> hard-to-find bug here! Good catch!

Good, that's why I made it a separate patch.

> Makes me wonder if anyone's written a tool to find things like this -
> #ifdefs that will never be defined...

Yeah, I thought the same thing; surely it would be nice...
Probably it's not only the one case, I suppose.

With regards,
André
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/