linux-kernel - Re: [PATCH 16/27] BKL: Remove BKL from efs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AEEB8A4.8000700@suse.de>
Date:	Mon, 02 Nov 2009 18:47:00 +0800
From:	Coly Li <coly.li@...e.de>
To:	Jan Blunck <jblunck@...e.de>
Cc:	linux-fsdevel@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 16/27] BKL: Remove BKL from efs

Acked-by: Coly Li <coly.li@...e.de>

On 2009年11月02日 18:04, Jan Blunck Wrote:
> BKL is only used in fill_super. It is safe to remove it.
> 
> Signed-off-by: Jan Blunck <jblunck@...e.de>
> ---
>  fs/efs/super.c |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/efs/super.c b/fs/efs/super.c
> index 0981141..f049428 100644
> --- a/fs/efs/super.c
> +++ b/fs/efs/super.c
> @@ -249,13 +249,9 @@ static int efs_fill_super(struct super_block *s, void *d, int silent)
>  	struct inode *root;
>  	int ret = -EINVAL;
>  
> -	lock_kernel();
> -
> -	sb = kzalloc(sizeof(struct efs_sb_info), GFP_KERNEL);
> -	if (!sb) {
> -		unlock_kernel();
> + 	sb = kzalloc(sizeof(struct efs_sb_info), GFP_KERNEL);
> +	if (!sb)
>  		return -ENOMEM;
> -	}
>  	s->s_fs_info = sb;
>   
>  	s->s_magic		= EFS_SUPER_MAGIC;
> @@ -323,14 +319,12 @@ static int efs_fill_super(struct super_block *s, void *d, int silent)
>  		goto out_no_fs;
>  	}
>  
> -	unlock_kernel();
>  	return 0;
>  
>  out_no_fs_ul:
>  out_no_fs:
>  	s->s_fs_info = NULL;
>  	kfree(sb);
> -	unlock_kernel();
>  	return ret;
>  }
>  

-- 
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/