linux-kernel - Re: [PATCH 10/27] BKL: Remove BKL from autofs4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AEEBEF1.8050807@themaw.net>
Date:	Mon, 02 Nov 2009 19:13:53 +0800
From:	Ian Kent <raven@...maw.net>
To:	Jan Blunck <jblunck@...e.de>
CC:	linux-fsdevel@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	linux-kernel@...r.kernel.org, James Morris <jmorris@...ei.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Jeff Moyer <jmoyer@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	autofs@...ux.kernel.org
Subject: Re: [PATCH 10/27] BKL: Remove BKL from autofs4

Jan Blunck wrote:
> BKL is only used in fill_super. It is safe to remove it.

Yes, I think so too.
Of course this will make co-coordinating the rename of autofs4 to autofs
a bit more painful, ;)

> 
> Signed-off-by: Jan Blunck <jblunck@...e.de>
Acked-by: Ian Kent <raven@...maw.net>

> ---
>  fs/autofs4/inode.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
> index 3adaba9..69c8142 100644
> --- a/fs/autofs4/inode.c
> +++ b/fs/autofs4/inode.c
> @@ -323,8 +323,6 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
>  	struct autofs_sb_info *sbi;
>  	struct autofs_info *ino;
>  
> -	lock_kernel();
> -
>  	sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
>  	if (!sbi)
>  		goto fail_unlock;
> @@ -420,7 +418,6 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
>  	 * Success! Install the root dentry now to indicate completion.
>  	 */
>  	s->s_root = root;
> -	unlock_kernel();
>  	return 0;
>  	
>  	/*
> @@ -442,7 +439,6 @@ fail_free:
>  	kfree(sbi);
>  	s->s_fs_info = NULL;
>  fail_unlock:
> -	unlock_kernel();
>  	return -EINVAL;
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/