linux-kernel - Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091102193623.GB9948@elte.hu>
Date:	Mon, 2 Nov 2009 20:36:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Joe Perches <joe@...ches.com>,
	André Goddard Rosa <andre.goddard@...il.com>,
	laijs@...fujitsu.com, davem@...emloft.net,
	akpm@...ux-foundation.org, harvey.harrison@...il.com,
	linux list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra
	check


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Mon, Nov 02, 2009 at 10:29:43AM -0800, Joe Perches wrote:
> > On Mon, 2009-11-02 at 19:19 +0100, Frederic Weisbecker wrote:
> > > On Mon, Nov 02, 2009 at 03:26:36PM -0200, André Goddard Rosa wrote:
> > > > Subject: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
> > > >    text    data     bss     dec     hex filename
> > > >   15735       0       8   15743    3d7f lib/vsprintf.o-before
> > > >   15719       0       8   15727    3d6f lib/vsprintf.o-minus-double-check
> > > Please add a changelog in your patches, I mean something that
> > > explain your practical change.
> > 
> > Read the subject and try not to go overboard.
> > I think the changelog André provided is perfect.
> 
> 
> It took me some time yesterday to understand how 
> ip6_compressed_string() does its job, hence it took me some time to 
> ensure this patch is safe, hence this reaction for something that 
> didn't seem obvious to me at a first glance.
> 
> But you're right actually, the problem was more in my homework than in 
> the changelog.

Since you wrote the last iteration of that bit and you didnt find it 
trivial i'd strongly suggest the next version of this patch to include a 
more verbose changelog that explains what is being done. There's no harm 
in being verbose about reasons for a change - and there's a lot of harm 
from being too short.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/