linux-kernel - Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF03720.5070506@csr.com>
Date:	Tue, 03 Nov 2009 13:58:56 +0000
From:	David Vrabel <david.vrabel@....com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Nicolas Pitre <nico@...xnic.net>, Alan Cox <alan@...ux.intel.com>,
	linux-mmc@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	dhowells@...hat.com
Subject: Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

Alan Cox wrote:
> 
> The claim method takes the mutex, checks if it is NULL and acts
> accordingly but it releases the mutex, which makes it useless as the code
> then uses port->func. If I move the release of the mutex to the
> release_func method then that fixes almost all cases.
> 
> The one I'm stuck on is this
> 
> 
> 		CPU1				CPU2
> 
> 
> 	sdio_uart_irq
> 					sdio_uart_port_remove
> 					port->func = NULL;
> 	sdio_in
> 	BUG_ON

This is actually happening?  sdio_claim_host()/sdio_release_host() act
like a mutex so sdio_uart_port_remove() will wait in sdio_claim_host()
until sdio_uart_irq() returns (SDIO interrupt handlers are called with
the host claimed).

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/