linux-kernel - Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Nov 2009 14:17:23 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Vrabel <david.vrabel@....com>
Cc:	Nicolas Pitre <nico@...xnic.net>, Alan Cox <alan@...ux.intel.com>,
	linux-mmc@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	dhowells@...hat.com
Subject: Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

> > 	sdio_uart_irq
> > 					sdio_uart_port_remove
> > 					port->func = NULL;
> > 	sdio_in
> > 	BUG_ON
> 
> This is actually happening?  sdio_claim_host()/sdio_release_host() act

Found by inspection

> like a mutex so sdio_uart_port_remove() will wait in sdio_claim_host()
> until sdio_uart_irq() returns (SDIO interrupt handlers are called with
> the host claimed).

Ok that was a detail I was missing. That part of the locking now makes
sense.

Ok so I think I have it fixed up barring stuff which is "feature add" -
such as implementing TIOCMIWAIT and blocking on no carrier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/