linux-kernel - Re: [PATCH 5/14] cpumask: use modern cpumask style in drivers/edac/amd64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091103064347.GA8082@liondog.tnic>
Date:	Tue, 3 Nov 2009 07:43:47 +0100
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org,
	Doug Thompson <dougthompson@...ssion.com>,
	Borislav Petkov <borislav.petkov@....com>,
	bluesmoke-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 5/14] cpumask: use modern cpumask style in
 drivers/edac/amd64_edac.c

Hi,

On Tue, Nov 03, 2009 at 02:56:35PM +1030, Rusty Russell wrote:
> cpumask_t -> struct cpumask, and don't put one on the stack.  (Note: this
> is actually on the stack unless CONFIG_CPUMASK_OFFSTACK=y).
> 
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

I've got a similar patch already queued up but it
depends on the changes to rdmsr_on_cpus/wrmsr_on_cpus in
b8a4754147d61f5359a765a3afd3eb03012aa052 which is in tip/x86/cpu and
which does a bit more than your patch 4 so IMHO you could drop yours.

Concerning the edac change, yours is better and I could pick it up and
add it to my patch queue if nobody else has a problem with that?

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/