linux-kernel - Re: 2.6.32-rc5-mmotm1101 - lockdep whinge during early boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091105141055.GA17350@redhat.com>
Date:	Thu, 5 Nov 2009 15:10:55 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Valdis.Kletnieks@...edu, Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: 2.6.32-rc5-mmotm1101 - lockdep whinge during early boot

On 11/05, Rusty Russell wrote:
>
> On Thu, 5 Nov 2009 02:41:24 am Valdis.Kletnieks@...edu wrote:
>  [    0.344147] swapper/1 is trying to acquire lock:
> > [    0.344154]  (cpu_add_remove_lock){+.+.+.}, at: [<ffffffff8103c222>] cpu_maps_update_begin+0x12/0x14
> > [    0.344174]
> > [    0.344175] but task is already holding lock:
> > [    0.344183]  (setup_lock){+.+.+.}, at: [<ffffffff81078755>] stop_machine_create+0x12/0x9b
> > [    0.344200]
> > [    0.344201] which lock already depends on the new lock.
>
> Hi Vladis!
>
>     Sigh.  I always find reading these a complete mindfuck.
>
> stop_machine_create: setup_lock then cpu_add_remove_lock
> 	(in create_workqueue_key() -> cpu_maps_update_begin())
> clocksource_done_booting: clocksource_mutex then setup_lock
> 	(in stop_machine_create(), as above)
> cpu_up: cpu_add_remove_lock then clocksource_mutex
> 	(in mark_tsc_unstable() -> clocksource_change_rating())
>
> AFAICT this is our circular dependency.  But I'm no closer to knowing how to
> solve it.

Not sure I understand this correctly, but afaics this dependency is
even simpler:

	cpu_up()->clocksource_change_rating() path takes clocksource_mutex
	under CPU hotplug locks.

	clocksource_done_booting()->create_workueue() path takes CPU hotplug
	locks under clocksource_mutex.

> Oleg (CC'd) made workqueues use cpu_maps_update_begin() instead of the
> more obvious get_online_cpus() in 3da1c84c00c7e5f.  Reverting that seems like
> a bad idea.

Even if create_workueue() used get_online_cpus() instead of cpu_add_remove_lock,
we have the same problem: _cpu_up() takes cpu_hotplug.lock which is needed for
get_online_cpus(). The dependency above becomes:

	cpu_up()->clocksource_change_rating() takes clocksource_mutex under
	cpu_hotplug.lock (cpu_hotplug_begin)

	clocksource_done_booting()->create_workueue() takes cpu_hotplug.lock
	(get_online_cpus) under clocksource_mutex

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/