lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Nov 2009 15:54:15 +0100 From: Martin Schwidefsky <schwidefsky@...glemail.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Rusty Russell <rusty@...tcorp.com.au>, Valdis.Kletnieks@...edu, Andrew Morton <akpm@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>, Heiko Carstens <heiko.carstens@...ibm.com> Subject: Re: 2.6.32-rc5-mmotm1101 - lockdep whinge during early boot That is imho caused by this patch snippet from the linux-next.patch from mmotd: diff -puN arch/x86/kernel/tsc.c~linux-next arch/x86/kernel/tsc.c --- a/arch/x86/kernel/tsc.c~linux-next +++ a/arch/x86/kernel/tsc.c @@ -763,14 +763,12 @@ void mark_tsc_unstable(char *reason) { if (!tsc_unstable) { tsc_unstable = 1; - printk(KERN_INFO "Marking TSC unstable due to %s\n", reason); + printk("Marking TSC unstable due to %s\n", reason); /* Change only the rating, when not registered */ if (clocksource_tsc.mult) - clocksource_mark_unstable(&clocksource_tsc); - else { - clocksource_tsc.flags |= CLOCK_SOURCE_UNSTABLE; + clocksource_change_rating(&clocksource_tsc, 0); + else clocksource_tsc.rating = 0; - } } } The upstream variant of mark_tsc_unstable uses clocksource_mark_unstable which does not take the mutex. The reason is the clocksource mutex vs. the cpu_add_remove_lock spinlock. -- blue skies, Martin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists