linux-kernel - Re: [PATCH -mm] char, moxa: Make isabrds variable global.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF54B77.2000605@gmail.com>
Date:	Sat, 07 Nov 2009 11:27:03 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Rakib Mullick <rakib.mullick@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm] char, moxa: Make isabrds variable global.

On 11/07/2009 06:08 AM, Rakib Mullick wrote:
> On 11/3/09, Rakib Mullick <rakib.mullick@...il.com> wrote:
>>  When CONFIG_MODULE=n and CONFIG_PCI=n, then variable
>>  isabrds becomes unused variable. So place it outside
>>  moxa_init solves this problem.
>>
>>   We were warned by the following warning:
>>
>>  drivers/char/moxa.c: In function `moxa_init':
>>  drivers/char/moxa.c:1012: warning: unused variable `isabrds'
> 
> Hi Andrew, after applying this one, it introduce a new warning:

Sorry I had no time to look into the first patch. And it makes no sense.
The driver is unusable on !MODULE && !PCI. So better fix is to disallow
whole build on such configurations. Care to fix that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/