[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b9df5fa10911081806m7564f778k35e0308fc5ddfba4@mail.gmail.com>
Date: Mon, 9 Nov 2009 08:06:47 +0600
From: Rakib Mullick <rakib.mullick@...il.com>
To: Jiri Slaby <jirislaby@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm] char, moxa: Make isabrds variable global.
On 11/7/09, Jiri Slaby <jirislaby@...il.com> wrote:
>
> Sorry I had no time to look into the first patch. And it makes no sense.
> The driver is unusable on !MODULE && !PCI. So better fix is to disallow
> whole build on such configurations. Care to fix that?
>
Hi Jiri, thanks for your care. Would you please checkout the
patch below? Is it okay?
moxa: Disallow moxa build when !MODULE && !PCI.
If MODULES support is not enabled then MODULE=y is not
possible.
Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
-----
--- linus/drivers/char/Kconfig 2009-11-06 13:45:42.000000000 +0600
+++ rakib/drivers/char/Kconfig 2009-11-08 21:31:48.000000000 +0600
@@ -216,7 +216,7 @@ config ESPSERIAL
config MOXA_INTELLIO
tristate "Moxa Intellio support"
- depends on SERIAL_NONSTANDARD && (ISA || EISA || PCI)
+ depends on SERIAL_NONSTANDARD && (ISA || EISA || PCI) || MODULES
select FW_LOADER
help
Say Y here if you have a Moxa Intellio multiport serial card.
@@ -226,7 +226,7 @@ config MOXA_INTELLIO
config MOXA_SMARTIO
tristate "Moxa SmartIO support v. 2.0"
- depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+ depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) || MODULES
help
Say Y here if you have a Moxa SmartIO multiport serial card and/or
want to help develop a new version of this driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists