linux-kernel - [tip:core/urgent] highmem: Fix race in debug_kmap_atomic() which could cause warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-5ebd4c22897dce65845807a9bd3a31cc4e142b53@git.kernel.org>
Date:	Tue, 10 Nov 2009 03:19:28 GMT
From:	tip-bot for Soeren Sandmann <sandmann@...mi.au.dk>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	torvalds@...ux-foundation.org, sandmann@...hat.com,
	sandmann@...mi.au.dk, tglx@...utronix.de, mingo@...e.hu
Subject: [tip:core/urgent] highmem: Fix race in debug_kmap_atomic() which could cause warn_count to underflow

Commit-ID:  5ebd4c22897dce65845807a9bd3a31cc4e142b53
Gitweb:     http://git.kernel.org/tip/5ebd4c22897dce65845807a9bd3a31cc4e142b53
Author:     Soeren Sandmann <sandmann@...mi.au.dk>
AuthorDate: Wed, 28 Oct 2009 18:55:36 +0100
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Tue, 10 Nov 2009 04:15:32 +0100

highmem: Fix race in debug_kmap_atomic() which could cause warn_count to underflow

debug_kmap_atomic() tries to prevent ever printing more than 10
warnings, but it does so by testing whether an unsigned integer
is equal to 0. However, if the warning is caused by a nested
IRQ, then this counter may underflow and the stream of warnings
will never end.

Fix that by using a signed integer instead.

Signed-off-by: Soeren Sandmann Pedersen <sandmann@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: a.p.zijlstra@...llo.nl
Cc: <stable@...nel.org> # .31.x
LKML-Reference: <ye8zl7b8ktj.fsf@...el23.daimi.au.dk>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 mm/highmem.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/highmem.c b/mm/highmem.c
index 25878cc..33587de 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -426,9 +426,9 @@ void __init page_address_init(void)
 
 void debug_kmap_atomic(enum km_type type)
 {
-	static unsigned warn_count = 10;
+	static int warn_count = 10;
 
-	if (unlikely(warn_count == 0))
+	if (unlikely(warn_count < 0))
 		return;
 
 	if (unlikely(in_interrupt())) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/