| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4AFD91DD.7000104@linux.vnet.ibm.com> Date: Fri, 13 Nov 2009 15:05:33 -0200 From: Breno Leitao <leitao@...ux.vnet.ibm.com> To: Linux Kernel Mailing List <linux-kernel@...r.kernel.org> CC: rjw@...k.pl Subject: PCI: pci_restore_state() is returning 0 when it fails Actually pci_restore_state() is returning 0 if the restore process fails, instead of a error value. If it fails, I believe that it should return -EPERM, once that it is an invalid operation and probably pci_save_state() wasn't called. Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com> --- drivers/pci/pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 4e4c295..b677ca3 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -857,7 +857,7 @@ pci_restore_state(struct pci_dev *dev) u32 val; if (!dev->state_saved) - return 0; + return -EPERM; /* PCI Express register must be restored first */ pci_restore_pcie_state(dev); -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists