linux-kernel - Re: [PATCH] libata: remove experimental tag on PATA drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Nov 2009 21:30:07 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Robert Hancock <hancockrwd@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	ide <linux-ide@...r.kernel.org>, Jeff Garzik <jgarzik@...ox.com>
Subject: Re: [PATCH] libata: remove experimental tag on PATA drivers

> > Not experimental as we default to not doing ATAPI DMA. Glancing over the
> 
> Which is a regression compared to the "old IDE" driver.

And given the two drivers show the difference when exactly the sequence
of I/O writes/reads occurs one that nobody plans to worry about as its
clearly some kind of hardware timing issue.

> > code I notice the ALI C2/C3 workaround probably wants adding to the old
> > driver as it can do nasty things otherwise. (See the reset function in
> > the pata_ali driver)
> 
> Please let the driver's maintainer know about it.
> 
> One would wonder why workaround hasn't been back-ported to stable driver

It's in the stable driver, might not be in drivers/ide. The note about it
being missing was posted out to various people at the time so I guess it
got missed

> > > PATA_CMD64X: EXPERIMENTAL
> > > - potential data corruption issues remains unfixed for CMD64[3,6]
> > 
> > Patch in testing, and unlike the old IDE one it doesn't cripple the
> > controller but implements the proper workaround in full including
> > permitting parallel PIO command streams. I'll push that back through
> > stable once done.
> 
> This patch is way too complex and risky for -rc, let alone -stable.

How would you know - I've not posted it yet ? And btw I don't plan to
post it for the -rc. Nor would simply posting a serializing hack fix it.
It might make it less likely to occur but that isn't a fix.

> > it. Trivial and fixed.
> 
> I can't see a fix anywhere but I'll assume that I can't look for it
> properly (I'm really sorry for it).

Fixed as in I fixed it now. Which is why I just noticed the old IDE ones
are buggy. I'll add it to the next patch sets for Jeff, along with the
Toshiba driver and some other bits.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/