linux-kernel - Re: [PATCH v3] perf tools: New function to parse string representing size in bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091115110432.GA19862@elte.hu>
Date:	Sun, 15 Nov 2009 12:04:32 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	paulus@...ba.org, fweisbec@...il.com
Subject: Re: [PATCH v3] perf tools: New function to parse string representing
 size in bytes


* Hitoshi Mitake <mitake@....info.waseda.ac.jp> wrote:

> > > +	length = atoll(str) * unit;
> > 
> > we might want to take a naming clue here and name this new function as 
> > atoll_exp(), to signal that it works like atoll, just with an extension 
> > for KB/MB/GB/etc. expressions?
> 
> Hm, how about "atoll_byteunit()"?
> This may have no ambiguity.

I'd suggest to name it in a generic way, in case we want to add other 
convenience conversions, hm?

Perhaps simply perf_atoll() - an extended version that understands byte 
units (and potentially more in the future).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/