[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20091115.203228.50774015.mitake@dcl.info.waseda.ac.jp>
Date: Sun, 15 Nov 2009 20:32:28 +0900 (JST)
From: Hitoshi Mitake <mitake@....info.waseda.ac.jp>
To: mingo@...e.hu
Cc: linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
paulus@...ba.org, fweisbec@...il.com
Subject: Re: [PATCH v3] perf tools: New function to parse string
representing size in bytes
From: Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v3] perf tools: New function to parse string representing size in bytes
Date: Sun, 15 Nov 2009 12:04:32 +0100
>
> * Hitoshi Mitake <mitake@....info.waseda.ac.jp> wrote:
>
> > > > + length = atoll(str) * unit;
> > >
> > > we might want to take a naming clue here and name this new function as
> > > atoll_exp(), to signal that it works like atoll, just with an extension
> > > for KB/MB/GB/etc. expressions?
> >
> > Hm, how about "atoll_byteunit()"?
> > This may have no ambiguity.
>
> I'd suggest to name it in a generic way, in case we want to add other
> convenience conversions, hm?
>
> Perhaps simply perf_atoll() - an extended version that understands byte
> units (and potentially more in the future).
OK. I name the function perf_atoll().
I'll send the patch later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists