| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4B01561A.4090109@redhat.com> Date: Mon, 16 Nov 2009 08:39:38 -0500 From: Prarit Bhargava <prarit@...hat.com> To: Ingo Molnar <mingo@...e.hu> CC: linux-kernel@...r.kernel.org, bhavna.sarathy@....com, jbarnes@...tuousgeek.org, andreas.herrmann3@....com Subject: Re: [PATCH]: AMD Northbridge: Verify NB's node is online >> >> Hardware maybe programmed incorrectly and return a bogus node ID. >> Check to see if the node is actually online before setting the numa >> node for an AMD northbridge in quirk_amd_nb_node(). >> > > Hm, could you stick a printk in there, what precise node ID does the > hardware return? > > Ingo, yup -- I put in a printk and commented out the set_dev_node() call when debugging this and got this output: quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x0 quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x1 quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x2 quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x3 The issue appears to be that the HW has set val to a valid value, however, the system is only configured for a single node -- 0. I realize that I'm working around broken HW ... but I think that a quirk, quirk_amd_nb_node(), should at least keep systems booting ... P. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists