linux-kernel - Re: [PATCH]: AMD Northbridge: Verify NB's node is online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091116144402.GA16696@elte.hu>
Date:	Mon, 16 Nov 2009 15:44:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, bhavna.sarathy@....com,
	jbarnes@...tuousgeek.org, andreas.herrmann3@....com
Subject: Re: [PATCH]: AMD Northbridge: Verify NB's node is online


* Prarit Bhargava <prarit@...hat.com> wrote:

> 
> >>
> >>Hardware maybe programmed incorrectly and return a bogus node
> >>ID.  Check to see if the node is actually online before setting
> >>the numa node for an AMD northbridge in quirk_amd_nb_node().
> >
> >Hm, could you stick a printk in there, what precise node ID does
> >the hardware return?
> >
> 
> Ingo, yup -- I put in a printk and commented out the set_dev_node()
> call when debugging this
> and got this output:
> 
> quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x0
> quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x1
> quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x2
> quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x3
> 
> The issue appears to be that the HW has set val to a valid value, 
> however, the system is only configured for a single node -- 0.
> 
> I realize that I'm working around broken HW ... but I think that a 
> quirk, quirk_amd_nb_node(), should at least keep systems booting ...

Ok. I cleaned up the patch a bit and added a comment explaining the 
logic - and also expanded the changelog with your new debug data, and 
applied it to tip:x86/urgent. Please check the commit notification email 
whether it's all OK.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/