linux-kernel - Re: [PATCH] procfs: Use proper units for noMMU statm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1258382853.3019.0.camel@iscandar.digidescorp.com>
Date:	Mon, 16 Nov 2009 08:47:33 -0600
From:	"Steven J. Magnani" <steve@...idescorp.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] procfs: Use proper units for noMMU statm

On Sat, 2009-11-14 at 12:41 +0800, Américo Wang wrote:
> On Fri, Nov 13, 2009 at 07:52:14PM -0600, steve@...idescorp.com wrote:
> >On no-MMU systems, sizes reported in /proc/n/statm have units of bytes. 
> >Per Documentation/filesystems/proc.txt, these values should be in pages.
> >
> > ...
> >
> >+	*data = (mm->start_stack - mm->start_data) >> PAGE_SHIFT;
> 
> Are '->start_stack' and '->start_data' already page aligned on NOMMU arch?
> 

In looking over binfmt_flat.c (main executable type for noMMU systems),
I don't think there's a guarantee of more than 32- or 64-bit alignment.
Thanks for the suggestion, I'll submit an updated patch.

------------------------------------------------------------------------
 Steven J. Magnani               "I claim this network for MARS!
 www.digidescorp.com              Earthling, return my space modulator!"

 #include <standard.disclaimer>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/