| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1258383053-3425-1-git-send-email-steve@digidescorp.com> Date: Mon, 16 Nov 2009 08:50:53 -0600 From: steve@...idescorp.com To: linux-kernel@...r.kernel.org Cc: xiyou.wangcong@...il.com, "Steven J. Magnani" <steve@...idescorp.com> Subject: [PATCH v2] procfs: Use proper units for noMMU statm Reworked to guarantee page alignment of terms used in data size calculation and to reduce time spent with mmap_sem held. On no-MMU systems, sizes reported in /proc/n/statm have units of bytes. Per Documentation/filesystems/proc.txt, these values should be in pages. Signed-off-by: Steven J. Magnani <steve@...idescorp.com> --- diff -uprN a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c --- a/fs/proc/task_nommu.c 2009-11-13 16:48:14.000000000 -0600 +++ b/fs/proc/task_nommu.c 2009-11-14 12:17:00.000000000 -0600 @@ -110,9 +110,13 @@ int task_statm(struct mm_struct *mm, int } } - size += (*text = mm->end_code - mm->start_code); - size += (*data = mm->start_stack - mm->start_data); + *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) + >> PAGE_SHIFT; + *data = (PAGE_ALIGN(mm->start_stack) - (mm->start_data & PAGE_MASK)) + >> PAGE_SHIFT; up_read(&mm->mmap_sem); + size >>= PAGE_SHIFT; + size += *text + *data; *resident = size; return size; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists