linux-kernel - Re: [PATCH] sysctl.c: Change a .proc_handler = proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1ws1pfpau.fsf@fess.ebiederm.org>
Date:	Tue, 17 Nov 2009 01:55:53 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	joe@...ches.com, mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to

Alexey Dobriyan <adobriyan@...il.com> writes:

>> -		.proc_handler	= proc_dointvec
>> +		.proc_handler	= &proc_dointvec,
>
> NAK.
>
> commit 6d9f239a1edb31d6133230f478fd1dc2da338ec5
> Author: Alexey Dobriyan <adobriyan@...il.com>
> Date:   Mon Nov 3 18:21:05 2008 -0800
>
>     net: '&' redux
>     
>     I want to compile out proc_* and sysctl_* handlers totally and
>     stub them to NULL depending on config options, however usage of &
>     will prevent this, since taking adress of NULL pointer will break
>     compilation.

I just experimented with this and found that at present a number of
the proc handlers wrap functions like proc_dointvec, so it does not work.

Did you have a plan for those?

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/