linux-kernel - Re: [PATCH] ftdi_sio: Keep going when write errors are encountered.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091118034401.GA17349@suse.de>
Date:	Tue, 17 Nov 2009 19:44:01 -0800
From:	Greg KH <gregkh@...e.de>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Johan Hovold <jhovold@...il.com>,
	Michael Trimarchi <trimarchi@...dalf.sssup.it>,
	linux-usb@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oliver@...kum.org>
Subject: Re: [PATCH] ftdi_sio:  Keep going when write errors are
 encountered.

On Tue, Nov 17, 2009 at 07:10:48PM -0800, Eric W. Biederman wrote:
> 
> The use of urb->actual_length to update tx_outstanding_bytes
> implicitly assumes that the number of bytes actually written is the
> same as the number of bytes we tried to write.  On error that
> assumption is violated so just use transfer_buffer_length the number
> of bytes we intended to write to the device.
> 
> If an error occurs we need to fall through and call
> usb_serial_port_softint to wake up processes waiting in
> tty_wait_until_sent.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Nice job, thanks for debugging this.  I'll go queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/