linux-kernel - Re: [PATCH 03/15] osst: Update ppos instead of using file->f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091120171317.GH20634@shareable.org>
Date:	Fri, 20 Nov 2009 17:13:17 +0000
From:	Jamie Lokier <jamie@...reable.org>
To:	Jan Blunck <jblunck@...e.de>
Cc:	linux-fsdevel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux-Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>, jkacur@...hat.com,
	Arnd Bergmann <arnd@...db.de>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Willem Riede <osst@...de.org>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>
Subject: Re: [PATCH 03/15] osst: Update ppos instead of using file->f_pos

Jan Blunck wrote:
> osst_read()/osst_write() modify file->f_pos directly instead of the ppos
> given to them. The VFS later updates the file->f_pos and overwrites it
> with the value of ppos.

I notice st.c doesn't use or update file->f_pos (or *ppos), so
userspace probably won't be caring about f_pos from osst.c (they're
both SCSI tape drivers).  And osst.c doesn't use the value, it just
increases it with each transfer.  It doesn't even reset the value to
zero when rewinding the tape, so it's not that meaningful.

So how about just removing those modifications to file->f_pos from osst.c?

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/