linux-kernel - [tip:sched/core] sched_feat_write(): Update ppos instead of file->f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-429947248f814e90f416ab4f68a871ab628000c3@git.kernel.org>
Date:	Mon, 23 Nov 2009 18:54:36 GMT
From:	tip-bot for Jan Blunck <jblunck@...e.de>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	jamie@...reable.org, peterz@...radead.org,
	alan@...rguk.ukuu.org.uk, jblunck@...e.de, hch@...radead.org,
	arnd@...db.de, fweisbec@...il.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:sched/core] sched_feat_write(): Update ppos instead of file->f_pos

Commit-ID:  429947248f814e90f416ab4f68a871ab628000c3
Gitweb:     http://git.kernel.org/tip/429947248f814e90f416ab4f68a871ab628000c3
Author:     Jan Blunck <jblunck@...e.de>
AuthorDate: Fri, 20 Nov 2009 17:40:37 +0100
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Mon, 23 Nov 2009 19:38:03 +0100

sched_feat_write(): Update ppos instead of file->f_pos

sched_feat_write() should update ppos instead of file->f_pos.

(This reduces some BKL dependencies of this code.)

Signed-off-by: Jan Blunck <jblunck@...e.de>
Cc: jkacur@...hat.com
Cc: Arnd Bergmann <arnd@...db.de>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Jamie Lokier <jamie@...reable.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Christoph Hellwig <hch@...radead.org>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
LKML-Reference: <1258735245-25826-8-git-send-email-jblunck@...e.de>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index ab9a034..93474a7 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -771,7 +771,7 @@ sched_feat_write(struct file *filp, const char __user *ubuf,
 	if (!sched_feat_names[i])
 		return -EINVAL;
 
-	filp->f_pos += cnt;
+	*ppos += cnt;
 
 	return cnt;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/