linux-kernel - Re: [PATCHv2 3/3] Define critical regulators as always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091125101407.GA17420@opensource.wolfsonmicro.com>
Date:	Wed, 25 Nov 2009 10:14:07 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Juha Keski-Saari <ext-juha.1.keski-saari@...ia.com>
Cc:	lrg@...mlogic.co.uk, dbrownell@...rs.sourceforge.net,
	linux-kernel@...r.kernel.org, peter.de-schrijver@...ia.com,
	eduardo.valentin@...ia.com
Subject: Re: [PATCHv2 3/3] Define critical regulators as always_on

On Wed, Nov 25, 2009 at 12:04:55PM +0200, Juha Keski-Saari wrote:

> +	if (pdev->id == TWL4030_REG_VIO ||
> +		pdev->id == TWL4030_REG_VDD1 ||
> +		pdev->id == TWL4030_REG_VDD2 ||
> +		pdev->id == TWL4030_REG_VPLL1 ||
> +		pdev->id == TWL4030_REG_VINTANA1 ||
> +		pdev->id == TWL4030_REG_VINTANA2 ||
> +		pdev->id == TWL4030_REG_VINTDIG)
> +		c->always_on = true;

This would be a bit clearer and much more idiomatic as a switch
statement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/