linux-kernel - Re: [PATCHv2 3/3] Define critical regulators as always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1259144999.10122.3.camel@keskisaa-workstation>
Date:	Wed, 25 Nov 2009 12:29:59 +0200
From:	Juha Keski-Saari <ext-juha.1.keski-saari@...ia.com>
To:	ext Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>,
	"dbrownell@...rs.sourceforge.net" <dbrownell@...rs.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"De-Schrijver Peter (Nokia-D/Helsinki)" 
	<Peter.De-Schrijver@...ia.com>,
	"Valentin Eduardo (Nokia-D/Helsinki)" <eduardo.valentin@...ia.com>
Subject: Re: [PATCHv2 3/3] Define critical regulators as always_on

On Wed, 2009-11-25 at 11:14 +0100, ext Mark Brown wrote:
> On Wed, Nov 25, 2009 at 12:04:55PM +0200, Juha Keski-Saari wrote:
> 
> > +	if (pdev->id == TWL4030_REG_VIO ||
> > +		pdev->id == TWL4030_REG_VDD1 ||
> > +		pdev->id == TWL4030_REG_VDD2 ||
> > +		pdev->id == TWL4030_REG_VPLL1 ||
> > +		pdev->id == TWL4030_REG_VINTANA1 ||
> > +		pdev->id == TWL4030_REG_VINTANA2 ||
> > +		pdev->id == TWL4030_REG_VINTDIG)
> > +		c->always_on = true;
> 
> This would be a bit clearer and much more idiomatic as a switch
> statement.

A switch statement sounds like a better idea, yes. Below is a version
that implements that change.

>>From 469f1f3fac05a740484cb32469b64aae424ba4de Mon Sep 17 00:00:00 2001
From: Juha Keski-Saari <ext-juha.1.keski-saari@...ia.com>
Date: Wed, 25 Nov 2009 11:10:35 +0200
Subject: [PATCHv3 3/3] Define critical regulators as always_on

Defines VIO, VDD1, VDD2, VPLL1 and VINT* regulators as always_on by
default
since they are critical to TWL and its master's functionality and should
be on in all cases where RegFW is used

Signed-off-by: Juha Keski-Saari <ext-juha.1.keski-saari@...ia.com>
---
 drivers/regulator/twl4030-regulator.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/twl4030-regulator.c
b/drivers/regulator/twl4030-regulator.c
index 7029fb9..02100bc 100644
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -456,6 +456,19 @@ static int twl4030reg_probe(struct platform_device
*pdev)
 	c->valid_ops_mask &= REGULATOR_CHANGE_VOLTAGE
 				| REGULATOR_CHANGE_MODE
 				| REGULATOR_CHANGE_STATUS;
+	switch(pdev->id) {
+		case TWL4030_REG_VIO:
+		case TWL4030_REG_VDD1:
+		case TWL4030_REG_VDD2:
+		case TWL4030_REG_VPLL1:
+		case TWL4030_REG_VINTANA1:
+		case TWL4030_REG_VINTANA2:
+		case TWL4030_REG_VINTDIG:
+			c->always_on = true;
+			break;
+		default:
+			break;
+	}
 
 	rdev = regulator_register(&info->desc, &pdev->dev, initdata, info);
 	if (IS_ERR(rdev)) {
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/