linux-kernel - Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0911251425q178993fete79b675e2730bdec@mail.gmail.com>
Date:	Wed, 25 Nov 2009 17:25:20 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	cliffcai.sh@...il.com, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, cliff.cai@...log.com,
	Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

On Wed, Nov 25, 2009 at 17:04, Andrew Morton wrote:
> On Wed, 25 Nov 2009 23:19:50 +0800 cliffcai.sh wrote:
>> +struct dma_desc_array {
>> +     unsigned long   start_addr;
>> +     unsigned short  cfg;
>> +     unsigned short  x_count;
>> +     short           x_modify;
>> +} __attribute__((packed));
>
> __packed is preferred.

we should move this into the Blackfin dma.h at any rate

>> +static void sdh_start_cmd(struct sdh_host *host, struct mmc_command *cmd)
>> +{
>> +     unsigned int sdh_cmd;
>> +     unsigned int stat_mask;
>> +
>> +     dev_dbg(mmc_dev(host->mmc), "%s enter cmd: 0x%p\n", __func__, cmd);
>> +     WARN_ON(host->cmd != NULL);
>> +     host->cmd = cmd;
>> +
>> +     sdh_cmd = 0;
>> +     stat_mask = 0;
>> +
>> +     sdh_cmd |= cmd->opcode;
>> +
>> +     if (cmd->flags & MMC_RSP_PRESENT) {
>> +             sdh_cmd |= CMD_RSP;
>> +             stat_mask |= CMD_RESP_END;
>> +     } else
>> +             stat_mask |= CMD_SENT;
>
> Arguably wrong from a coding-style POV and looks weird IMO.  Adds a bit
> of risk that subsequent coders will think they're writing in python adn
> will add bugs.

i dont really get what you're referring to here.  the code in question
looks ifne to me, and i dont see anything "python-esque" about it

> Fixes:
>
> -       } else
> +       } else }

guessing you actually meant '{' there
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/