linux-kernel - Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Nov 2009 16:39:16 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	cliffcai.sh@...il.com, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, cliff.cai@...log.com,
	Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

On Wed, Nov 25, 2009 at 17:43, Andrew Morton wrote:
> On Wed, 25 Nov 2009 17:25:20 -0500 Mike Frysinger wrote:
>> > Arguably wrong from a coding-style POV and looks weird IMO. __Adds a bit
>> > of risk that subsequent coders will think they're writing in python adn
>> > will add bugs.
>>
>> i dont really get what you're referring to here.  the code in question
>> looks ifne to me, and i dont see anything "python-esque" about it
>
> Code like
>
>        if (expr) {
>                line1;
>                line2;
>        } else
>                line3;
>
> looks odd and can cause people to later add bugs along the lines of
>
>        if (expr) {
>                line1;
>                line2;
>        } else
> +               line3a;
>                line3;
>
> this is particularly the case if line3 is long, or is preceded by a
> comment.  This has happened in the past.
>
> Adding the missing braces reduces the risk that this will occur.

*shrug* people can screw up braces regardless of how many statements
and/or branches there are.  i doubt people are going to get confused
and think kernel code is python, but if you really want to be pedantic
about braces, doesnt matter that much to me.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/