linux-kernel - Re: [PATCH] mfd: twl4030: Driver for twl4030 madc module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091130185221.1215213f@hyperion.delvare>
Date:	Mon, 30 Nov 2009 18:52:21 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Amit Kucheria <amit.kucheria@...durent.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	List Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-omap@...r.kernel.org, Mikko Ylinen <mikko.k.ylinen@...ia.com>
Subject: Re: [PATCH] mfd: twl4030: Driver for twl4030 madc module

On Mon, 30 Nov 2009 15:58:39 +0200, Amit Kucheria wrote:
> On Fri, Nov 27, 2009 at 9:36 PM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> > By the way, have you considered moving this one to drivers/hwmon ?
> 
> I haven't. I moved it from i2c/chips/ to the most obvious place I
> could think of - drivers/mfd. But wasn't this the point of mfd - that
> various subcomponents drivers could live there instead of being
> scattered across the driver tree?
> 
> Adding Jean to CC, if he would consider taking this driver in drivers/hwmon..

In its current form, no. This driver doesn't implement the sysfs
interface described in Documentation/hwmon/sysfs-interface. It doesn't
even register a hwmon class device. So it doesn't belong in
drivers/hwmon.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/