linux-kernel - Re: [Patch] selinux: remove an unreachable line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B14D468.2090502@redhat.com>
Date:	Tue, 01 Dec 2009 16:31:36 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	linux-kernel@...r.kernel.org, Eric Paris <eparis@...isplace.org>,
	linux-security-module@...r.kernel.org, akpm@...ux-foundation.org,
	James Morris <jmorris@...ei.org>
Subject: Re: [Patch] selinux: remove an unreachable line

Joe Perches wrote:
> On Tue, 2009-12-01 at 02:41 -0500, Amerigo Wang wrote:
>> This line is unreachable, remove it.
> []
>> diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
>> index b5407f1..a2f1034 100644
>> --- a/security/selinux/ss/mls.c
>> +++ b/security/selinux/ss/mls.c
>> @@ -544,7 +544,6 @@ int mls_compute_sid(struct context *scontext,
>>  	default:
>>  		return -EINVAL;
>>  	}
>> -	return -EINVAL;
>>  }
> 
> I think it's better to remove the default case.
> 

This is totally a personal taste, I think.
Either is OK. James, any comments?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/