linux-kernel - Re: [Patch] selinux: remove an unreachable line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0912012131440.27592@tundra.namei.org>
Date:	Tue, 1 Dec 2009 21:33:35 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Cong Wang <amwang@...hat.com>
cc:	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	Eric Paris <eparis@...isplace.org>,
	linux-security-module@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [Patch] selinux: remove an unreachable line

On Tue, 1 Dec 2009, Cong Wang wrote:

> > >  	default:
> > >  		return -EINVAL;
> > >  	}
> > > -	return -EINVAL;
> > >  }
> > 
> > I think it's better to remove the default case.
> > 
> 
> This is totally a personal taste, I think.
> Either is OK. James, any comments?

Leave the default: there but with a comment /* fall through */
instead of the return.



-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/