linux-kernel - Re: Re: [PATCH 1/3]fs/inode: iunique() Optimize Performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Dec 2009 10:42:50 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Liuweni <qingshenlwy@...il.com>, strongzgy <strongzgy@...il.com>,
	xgr178 <xgr178@....com>, Liu Hui <onlyflyer@...il.com>,
	viro <viro@...iv.linux.org.uk>, akpm <akpm@...ux-foundation.org>,
	jack <jack@...e.cz>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH 1/3]fs/inode: iunique() Optimize Performance

On Tue, Dec 01, 2009 at 07:00:41AM -0700, Matthew Wilcox wrote:
> On Tue, Dec 01, 2009 at 09:21:32PM +0800, Liuweni wrote:
> >  *	BUGS:
> >  *	With a large number of inodes live on the file system this function
> >  *	currently becomes quite slow.
> > 
> 
> I don't believe that comment is correct.  In any case, your optimisation
> wouldn't make a lick of difference to the speed; it's a single comparison
> in a loop which also calculates a hash, makes a function call, and walks
> the length of a hash chain.
> 
> The old adage about debugging code, not comments applies here.  Don't take
> somebody else's word for it that there's a performance problem here.
> Devise a test to demonstrate the performance problem.  Otherwise, how
> will you know if you solved it?

Yeah I agree. And then we can debate the usefulness of that workload.

iunique is not used in many filesystems.  If performance really becomes a
problem, then you most likely need another data structure. A per-sb ida or
something would come to mind, but I expect any filesystem that cares already
has a decent inode number allocation so iunique is just a simple hack for
those that don't care so much.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/