lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Dec 2009 11:09:28 +0100 From: Ingo Molnar <mingo@...e.hu> To: Xiaotian Feng <dfeng@...hat.com> Cc: x86@...nel.org, linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, Yinghai Lu <yinghai@...nel.org> Subject: Re: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put * Xiaotian Feng <dfeng@...hat.com> wrote: > pci_get_device increments reference count to the found pci device, > that should be decremented using pci_dev_put. > +++ b/arch/x86/kernel/reboot_fixups_32.c > @@ -80,6 +80,7 @@ void mach_reboot_fixups(void) > continue; > > cur->reboot_fixup(dev); > + pci_dev_put(dev); Does this matter in practice? We are about to reboot. (but if it's cleaner to do it like this or if there's some real bug fixed by this then please spell it out in the changelog.) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists