linux-kernel - Re: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B169B1B.8010007@zytor.com>
Date:	Wed, 02 Dec 2009 08:51:39 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Xiaotian Feng <dfeng@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put

On 12/02/2009 02:09 AM, Ingo Molnar wrote:
> 
> * Xiaotian Feng <dfeng@...hat.com> wrote:
> 
>> pci_get_device increments reference count to the found pci device, 
>> that should be decremented using pci_dev_put.
> 
>> +++ b/arch/x86/kernel/reboot_fixups_32.c
>> @@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
>>  			continue;
>>  
>>  		cur->reboot_fixup(dev);
>> +		pci_dev_put(dev);
> 
> Does this matter in practice? We are about to reboot. (but if it's 
> cleaner to do it like this or if there's some real bug fixed by this 
> then please spell it out in the changelog.)
> 

Even if it doesn't actually matter, doing things cleanly makes it easier
to handle failure scenarios, possibly that are discovered in the future.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/