linux-kernel - Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1259761934.12870.12.camel@gandalf.stny.rr.com>
Date:	Wed, 02 Dec 2009 08:52:14 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	mingo@...hat.com, hpa@...or.com, mathieu.desnoyers@...ymtl.ca,
	linux-kernel@...r.kernel.org, randy.dunlap@...cle.com,
	wcohen@...hat.com, fweisbec@...il.com, tglx@...utronix.de,
	jbaron@...hat.com, mhiramat@...hat.com, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] tracing: Add DEFINE_EVENT(),
 DEFINE_SINGLE_EVENT() support to docbook

On Wed, 2009-12-02 at 10:42 +0000, tip-bot for Jason Baron wrote:
> Commit-ID:  3a9089fd78367e2c6c815129030b790a0f5c2715
> Gitweb:     http://git.kernel.org/tip/3a9089fd78367e2c6c815129030b790a0f5c2715
> Author:     Jason Baron <jbaron@...hat.com>
> AuthorDate: Tue, 1 Dec 2009 12:18:49 -0500
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Wed, 2 Dec 2009 09:57:37 +0100
> 
> tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook

Ug, I need more sleep, because I never noticed the "SINGLE" when I acked
this :-p

I thought the DEFINE_SINGLE_EVENT was still under discussion because it
is a confusing name. I suggested to call it exactly what is was.

 DECLARE_CLASS_AND_DEFINE_EVENT()

-- Steve

> 
> The introduction of the new 'DECLARE_EVENT_CLASS()' obviates the
> need for the 'TRACE_EVENT()' macro in some cases. Thus, docbook
> style comments that used to live with 'TRACE_EVENT()' are now
> moved to 'DEFINE_EVENT()'. Thus, we need to make the docbook
> system understand the new 'DEFINE_EVENT()' macro. In addition
> I've tried to futureproof the patch, by also adding support for
> 'DEFINE_SINGLE_EVENT()', since there has been discussion about
> renaming: TRACE_EVENT() -> DEFINE_SINGLE_EVENT().
> 
> Without this patch the tracepoint docbook fails to build.
> 
> I've verified that this patch correctly builds the tracepoint
> docbook which currently covers signals, and irqs.
> 
> Changes in v2:
>  - properly indent perl 'if' statements
> 
> Signed-off-by: Jason Baron <jbaron@...hat.com>
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
> Acked-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: William Cohen <wcohen@...hat.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
> Cc: Masami Hiramatsu <mhiramat@...hat.com>
> LKML-Reference: <200912011718.nB1HIn7t011371@...-mx04.intmail.prod.int.phx2.redhat.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/