linux-kernel - Re: [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Dec 2009 15:05:33 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Veaceslav Falico <vfalico@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Al Viro <viro@...iv.linux.org.uk>,
	Miloslav Trmac <mitr@...hat.com>,
	James Morris <jmorris@...ei.org>,
	Alan Cox <alan@...ux.intel.com>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Renaud Lottiaux <renaud.lottiaux@...labs.com>,
	Louis Rilling <louis.rilling@...labs.com>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and
	taskstats_tgid_init()

On 12/01, Veaceslav Falico wrote:
>
> Remove unneeded initializations in acct_init_pacct() and taskstats_tgid_init().
> These are accessed only via copy_signal().
>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
> ---
>
> diff --git a/include/linux/taskstats_kern.h b/include/linux/taskstats_kern.h
> index 3398f45..d66167a 100644
> --- a/include/linux/taskstats_kern.h
> +++ b/include/linux/taskstats_kern.h
> @@ -16,7 +16,6 @@ extern struct mutex taskstats_exit_mutex;
>
>  static inline void taskstats_tgid_init(struct signal_struct *sig)
>  {
> -	sig->stats = NULL;
>  }
>
>  static inline void taskstats_tgid_free(struct signal_struct *sig)
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 9a4715a..8909c26 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -592,8 +592,6 @@ out:
>   */
>  void acct_init_pacct(struct pacct_struct *pacct)
>  {
> -	memset(pacct, 0, sizeof(struct pacct_struct));
> -	pacct->ac_utime = pacct->ac_stime = cputime_zero;
>  }

Looks good imho. But please note that with this patch both
taskstats_tgid_init() and acct_init_pacct() become empty, and we
already have "empty" definitions for #ifndef case.

Perhaps it makes sense to move this (now empty) helper outside
of #ifdef, or just kill it.

Up to maintainres.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/