linux-kernel - Re: [PATCH 01/21] blkio: Set must_dispatch only if we decided to not dispatch the request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49iqcplbbv.fsf@segfault.boston.devel.redhat.com>
Date:	Wed, 02 Dec 2009 09:06:28 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	linux-kernel@...r.kernel.org, jens.axboe@...cle.com,
	nauman@...gle.com, dpshah@...gle.com, lizf@...fujitsu.com,
	ryov@...inux.co.jp, fernando@....ntt.co.jp, s-uchida@...jp.nec.com,
	taka@...inux.co.jp, guijianfeng@...fujitsu.com,
	righi.andrea@...il.com, m-ikeda@...jp.nec.com, czoccolo@...il.com,
	Alan.Brunelle@...com
Subject: Re: [PATCH 01/21] blkio: Set must_dispatch only if we decided to not dispatch the request

Vivek Goyal <vgoyal@...hat.com> writes:

> o must_dispatch flag should be set only if we decided not to run the quue
>   dispatch the request.
>
> Signed-off-by: Vivek Goyal <vgoyal@...hat.com>
> ---
>  block/cfq-iosched.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index a5de31f..9adfa48 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -2494,9 +2494,9 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
>  			if (blk_rq_bytes(rq) > PAGE_CACHE_SIZE ||
>  			    cfqd->busy_queues > 1) {
>  				del_timer(&cfqd->idle_slice_timer);
> -			__blk_run_queue(cfqd->queue);
> -			}
> -			cfq_mark_cfqq_must_dispatch(cfqq);
> +				__blk_run_queue(cfqd->queue);
> +			} else
> +				cfq_mark_cfqq_must_dispatch(cfqq);
>  		}
>  	} else if (cfq_should_preempt(cfqd, cfqq, rq)) {
>  		/*

This makes sense, but could be submitted as a bugfix on its own.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/