linux-kernel - Re: [PATCH v2] mm: Introduce coredump parameter structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Dec 2009 19:29:33 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Oleg Nesterov <oleg@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	linux-kernel@...r.kernel.org, dhowells@...hat.com,
	hidehiro.kawai.ez@...achi.com, lethal@...ux-sh.org, mingo@...e.hu,
	roland@...hat.com, vapier@...too.org,
	Takahiro Yasui <tyasui@...hat.com>
Subject: Re: [PATCH v2] mm: Introduce coredump parameter structure

Andrew Morton wrote:
> On Sat, 28 Nov 2009 23:41:19 -0500
> Masami Hiramatsu<mhiramat@...hat.com>  wrote:
>
>> Introduce coredump parameter data structure (struct coredump_params)
>> for simplifying binfmt->core_dump() arguments.
>>
>> Changes in v2:
>>     - Don't remove DUMP_WRITE() macro.
>
> What is the reason for this change?
>
> Please always include both the "what" and the "why" in changelog text.

I see.

>
>> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
>> index b639dcf..346b694 100644
>> --- a/fs/binfmt_aout.c
>> +++ b/fs/binfmt_aout.c
>> @@ -32,7 +32,7 @@
>>
>>      static int load_aout_binary(struct linux_binprm *, struct pt_regs * regs);
>>      static int load_aout_library(struct file*);
>> -static int aout_core_dump(long signr, struct pt_regs *regs, struct file *file, unsigned long limit);
>> +static int aout_core_dump(struct coredump_params *cprm);
>>
>>      static struct linux_binfmt aout_format = {
>>      	.module		= THIS_MODULE,
>> @@ -89,8 +89,9 @@ if (file->f_op->llseek) { \
>>       * dumping of the process results in another error..
>>       */
>>
>> -static int aout_core_dump(long signr, struct pt_regs *regs, struct file *file, unsigned long limit)
>> +static int aout_core_dump(struct coredump_params *cprm)
>>      {
>
> Something horrid has mangled your patch.

Oops, sorry. maybe copy-and-paste buffer demon did it :-(

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/