linux-kernel - Re: [PATCH] x86: slightly shorten __ticket_spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4B17AB6102000078000235B0@vpn.id2.novell.com>
Date:	Thu, 03 Dec 2009 11:13:21 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>, <tglx@...utronix.de>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Nick Piggin" <npiggin@...e.de>, <linux-kernel@...r.kernel.org>,
	<hpa@...or.com>
Subject: Re: [PATCH] x86: slightly shorten __ticket_spin_trylock() (v2)

>>> Ingo Molnar <mingo@...e.hu> 03.12.09 11:49 >>>
>Looks much cleaner - and should give us pretty much the same savings as 
>the previous patch, right? (if not, do you have a size comparison?)

With upstream code there doesn't appear to be a difference in the
generated code. I noted, however, that with the spinlock contention
patch I have pending as a potential replacement for pv-ops spin locks
(which adds a conditional in the trylock functions) the compiler I use
no longer eliminates one of the two tests of the outcome of the
locking attempt.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/