linux-kernel - Re: [PATCH v2 1/2] acpi: support IBM SMBus CMI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091204180707.GM10295@tux1.beaverton.ibm.com>
Date:	Fri, 4 Dec 2009 10:07:07 -0800
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	lenb@...nel.org, Crane Cai <crane.cai@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-i2c@...r.kernel.org, linux-acpi@...r.kernel.org,
	Jean Delvare <khali@...ux-fr.org>
Subject: Re: [PATCH v2 1/2] acpi: support IBM SMBus CMI devices

On Fri, Dec 04, 2009 at 10:36:35AM -0700, Bjorn Helgaas wrote:
> On Friday 04 December 2009 10:06:21 am Darrick J. Wong wrote:
> > On Tue, Oct 27, 2009 at 06:36:19PM +0100, Jean Delvare wrote:
> > > On Tue, 27 Oct 2009 10:30:01 -0700, Darrick J. Wong wrote:
> > > > On Tue, Oct 27, 2009 at 06:03:32PM +0100, Jean Delvare wrote:
> > > > 
> > > > > I'm only half please with this. You change the function named, but it
> > > > > doesn't follow the calling convention of acpi_dock_match(), which is a
> > > > > little confusing.
> > > > > 
> > > > > Anyway, I will need an ack from the ACPI people before I can pick this
> > > > > patch. Or maybe they should even push it upstream themselves.
> > 
> > Len/Bjorn: Any opinion on this ACPI quirk patch to make i2c-scmi work on IBM
> > systems?  I think the i2c-scmi part is in Jean's tree, but I still need this
> > second patch to the ACPI code itself.  Did you pick it up, or should I resend?
> 
> I'm a little confused as to where we left things.  Can you repost
> the current series in a new thread?  It looks like there might be
> places that use "SMBUSIBM" when they should use ACPI_SMBUS_IBM_HID.

That was fixed in the patch that Jean picked up, which is why I especially need
the ACPI portion which actually #defines ACPI_SMBUS_IBM_HID. :)  I will repost
both patches soon.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/