linux-kernel - Re: [PATCH] Driver core: fix race in dev_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0912041555430.3070-100000@iolanthe.rowland.org>
Date:	Fri, 4 Dec 2009 15:57:50 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Oliver Neukum <oliver@...kum.org>
cc:	Greg KH <gregkh@...e.de>, <stable@...nel.org>,
	Rickard Bellini <rickard.bellini@...csson.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Torgny Johansson <torgny.johansson@...csson.com>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Driver core: fix race in dev_driver_string

On Fri, 4 Dec 2009, Oliver Neukum wrote:

> > > 1. am I supposed to get a reference just so that I can use dev_err?
> > 
> > No, you should already have a reference on the device when doing the
> > call, right?
> 
> No, why? Consider this:
> 
> int write(...)
> {
> 	...
> 	mutex_lock(&instance->lock);
> 	if (instance->disconnected) {
> 		dev_dbg(instance->dev,"writing to disconnected device"); 
> 		rv = -ENODEV;
> 	} else {
> 		res = usb_submit_urb(...);
> 		rv = res < 0 ? -EIO : count;
> 	}
> 	mutex_unlock(&instance->lock);
> 	return rv;
> }
> 
> void disconnect(...)
> {
> 	...
> 	mutex_lock(&instance->lock);
> 	instance->disconnected = 1;
> 	usb_kill_urb(...);
> 	usb_kill_urb(...);
> 	mutex_unlock(&instance->lock);
> }
> 
> This would be perfectly valid code without any references taken save
> for the pesky dev_dbg()

Whoever calls write() must possess a valid reference.  Otherwise 
instance might already be deallocated when write() starts, causing an 
oops well before the call to dev_dbg().

Typically the driver would take a reference during open() and drop it 
during close().

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/