linux-kernel - Re: [PATCH] scripts/checkpatch.pl: Add warning about leading contination tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091206131324.55436006@hyperion.delvare>
Date:	Sun, 6 Dec 2009 13:13:24 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>,
	William Allen Simpson <william.allen.simpson@...il.com>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add warning about leading
 contination tests

On Sun, 06 Dec 2009 09:35:04 +0100, Eric Dumazet wrote:
> Joe Perches a écrit :
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index bc4114f..c35933a 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2064,6 +2064,11 @@ sub process {
> >  			CHK("multiple assignments should be avoided\n" . $herecurr);
> >  		}
> >  
> > +# Check use of leading logical continuation tests
> > +		if ($line =~ /^.\s*(\|\||&&)/) {
> > +			WARN("Continuation logic should be at end of previous line\n" . $herecurr);
> > +		}
> > +
> >  ## # check for multiple declarations, allowing for a function declaration
> >  ## # continuation.
> >  ## 		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
> > 
> > 
> 
> Fine with me, but please add relevant info in Documentation/CodingStyle ?

Not fine with me. Placing the binary logic operator at the beginning
of a line can be a deliberate choice, either to make complex binary
expressions more readable, or to avoid long lines. I don't see much
point in banning this style, which BTW is used over 8000 times in the
current kernel tree.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/