linux-kernel - Re: [PATCH] scripts/checkpatch.pl: Add warning about leading contination tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1260121576.11126.83.camel@Joe-Laptop.home>
Date:	Sun, 06 Dec 2009 09:46:16 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Andy Whitcroft <apw@...onical.com>,
	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>,
	William Allen Simpson <william.allen.simpson@...il.com>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add warning about leading
 contination tests

On Sun, 2009-12-06 at 13:13 +0100, Jean Delvare wrote:
> Not fine with me. Placing the binary logic operator at the beginning
> of a line can be a deliberate choice, either to make complex binary
> expressions more readable, or to avoid long lines. I don't see much
> point in banning this style, which BTW is used over 8000 times in the
> current kernel tree.

Anyone that thinks that checkpatch is the
last word on linux coding style and all of
its pronouncements must be followed all the
time is simply wrong.

It's not a ban.  It's neither a command nor
an edict.  It's a warning.  It's a notice
that leading logical continuations are not
the preferred style and it can be ignored
at will.

I think it's rather like the long line, >80
column warning.  There are a whole lot more
than 8k long lines in kernel source and no
one is suggesting reformatting all of them
out of existence.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/