linux-kernel - Re: Block IO Controller V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2009 10:25:31 -0500
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
Cc:	jens.axboe@...cle.com, linux-kernel@...r.kernel.org,
	nauman@...gle.com, dpshah@...gle.com, lizf@...fujitsu.com,
	ryov@...inux.co.jp, fernando@....ntt.co.jp, s-uchida@...jp.nec.com,
	taka@...inux.co.jp, jmoyer@...hat.com, righi.andrea@...il.com,
	m-ikeda@...jp.nec.com, czoccolo@...il.com, Alan.Brunelle@...com
Subject: Re: Block IO Controller V4

On Mon, Dec 07, 2009 at 04:45:49PM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> > On Thu, Dec 03, 2009 at 01:10:03PM -0500, Vivek Goyal wrote:
> > 
> > [..]
> >> Hi Gui,
> >>
> >> Can you please try following patch and see if it helps you. If not, then
> >> we need to figure out why we choose to not idle and delete the group from
> >> service tree.
> >>
> > 
> > Hi Gui,
> > 
> > Please try this version of the patch instead of previous one. During more
> > testing I saw some additional deletions where we should have waited and
> > the reason being that we were hitting boundary condition. At the request
> > completion time slice has not expired but after 4-5 ns, select_queue hits
> > and jiffy has incremented by then and slice expires.
> > 
> > ttime_mean, is not covering this condition because this workload is so
> > sequential that ttime_mean=0.
> > 
> > So I am checking for new condition where if we are into last ms of slice,
> > mark the queue wait_busy.
> > 
> > Thanks
> > Vivek
> > 
> > Signed-off-by: Vivek Goyal <vgoyal@...hat.com>
> 
> Hi, Vivek
> 
> I add some debug message in select_queue, it does meet the boundary condition. 
> I tried this patch, and works fine on my box.
> 
> Acked-by: Gui Jianfeng <guijiafneng@...fujitsu.com>

Thanks Gui, I will send this patch to Jens in a separate mail.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/