linux-kernel - RE: [PATCH 3/5] drivers/infiniband: correct size computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2009 09:38:55 -0700
From:	"Tung, Chien Tin" <chien.tin.tung@...el.com>
To:	Julia Lawall <julia@...u.dk>
CC:	"Latif, Faisal" <faisal.latif@...el.com>,
	Roland Dreier <rolandd@...co.com>,
	"Hefty, Sean" <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 3/5] drivers/infiniband: correct size computation

>> > 	/* Remap the PCI registers in adapter BAR0 to kernel VA space */
>> >-	mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), sizeof(mmio_regs));
>> >+	mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0),
>> >+				    sizeof(*mmio_regs));
>> > 	if (mmio_regs == NULL) {
>> > 		printk(KERN_ERR PFX "Unable to remap BAR0\n");
>> > 		ret = -EIO;
>>
>> mmio_regs is initialized to NULL at the top of the function so
>> *mmio_regs wouldn't be a good idea.  Instead of sizeof(*mmio_regs) use
>> pci_resource_len(pcidev, BAR_0).  If you can recreate the patch with
>> this change I will ack it.
>
>When you say that it isn't a good idea, do you mean that the result is
>wrong, or that it looks odd?  I didn't think sizeof looked at the value,
>but only at the type?


I misspoke on the problem.  Mmio_regs is declared as a void pointer:

        void __iomem *mmio_regs = NULL;

Thus pci_resource_len(pcidev, BAR_0) is the correct fix.

Chien


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/