linux-kernel - Re: [PATCH] fib-trie: code cleanup (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091208112813.42ca3cca@nehalam>
Date:	Tue, 8 Dec 2009 11:28:13 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Robert Olsson <robert.olsson@....uu.se>,
	Jens Laas <jens.laas@...a.slu.se>,
	Hans Liss <hans.liss@....uu.se>,
	"Paul E. McKenney" <paulmck@...ibm.com>,
	Patrick McHardy <kaber@...sh.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fib-trie: code cleanup (v2)

On Tue, 8 Dec 2009 14:25:09 -0500
Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> * Stephen Hemminger (shemminger@...ux-foundation.org) wrote:
> > On Tue, 8 Dec 2009 13:48:39 -0500
> > Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:
> > 
> > >  	/* use cache location of last found key */
> > > -	if (iter->pos > 0 && pos >= iter->pos && (l = fib_find_node(t, iter->key)))
> > > -		pos -= iter->pos;
> > > +	if (iter->pos > 0 && pos >= iter->pos)
> > > +		l = fib_find_node(t, iter->key);
> > > +		if (l)
> > > +			pos -= iter->pos;
> > >  	else {
> > 
> > Missing bracket's here change the semantics.  
> 
> Ouch, yes. thanks.
> 
> 

The original code works and was clean enough, to split the assignment
out would require duplicate code.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/