linux-kernel - Re: [PATCH] fib-trie: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091208112910.7a1a3d43@nehalam>
Date:	Tue, 8 Dec 2009 11:29:10 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Robert Olsson <robert.olsson@....uu.se>,
	Jens Laas <jens.laas@...a.slu.se>,
	Hans Liss <hans.liss@....uu.se>,
	"Paul E. McKenney" <paulmck@...ibm.com>,
	Patrick McHardy <kaber@...sh.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fib-trie: code cleanup

On Tue, 8 Dec 2009 14:20:06 -0500
Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> * Stephen Hemminger (shemminger@...ux-foundation.org) wrote:
> > On Tue, 8 Dec 2009 13:48:39 -0500
> > Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:
> > 
> > > -	while ( (tb_node = rcu_dereference(tb->tb_hlist.next)) ) {
> > > +	while ((tb_node = rcu_dereference(tb->tb_hlist.next))) {
> > >  
> > 
> > This is clearer before with the added whitespace, ignore checkpatch natterings.
> 
> OK
> 
> Then we should do the same for all assignment within while() :
> 
> static void tnode_free_flush(void)
> {
>         struct tnode *tn;
> 
>         while ( (tn = tnode_free_head) ) {
> 
> ...
> 
> static struct leaf *leaf_walk_rcu(struct tnode *p, struct node *c)
> {
> .....
>                /* Node empty, walk back up to parent */
>                 c = (struct node *) p;
>         } while ( (p = node_parent_rcu(c)) != NULL);
> 
>         return NULL; /* Root of trie */
> }
> 
> 
> > 
> > -- 
> 

Yes, consistency on this makes sense.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/