linux-kernel - Re: [patch 2/2] x86,apic: Use logical OR in noop-write operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091208204838.GA26156@lenovo>
Date:	Tue, 8 Dec 2009 23:48:38 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	tglx@...utronix.de, mingo@...e.hu, hpa@...or.com,
	macro@...ux-mips.org, yinghai@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 2/2] x86,apic: Use logical OR in noop-write operation

On Tue, Dec 08, 2009 at 06:53:18PM +0300, Cyrill Gorcunov wrote:
> For apic noop'ified we have to use logical OR statement,
> otherwise any write on systems shipped with 82489DX
> (where apic presence bit can't be retrieved via cpuid)
> will not trigger the warning which is not desired.
>
...

Ingo please dont apply this patch. Perhaps we may warn unconditionally
(as Peter marked) which would be more clear approach indeed. Need more
time to check all code flows.

Sorry for inconvenience.

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/