[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091209145619.GA5788@lenovo>
Date: Wed, 9 Dec 2009 17:56:19 +0300
From: Cyrill Gorcunov <gorcunov@...il.com>
To: tglx@...utronix.de, mingo@...e.hu, hpa@...or.com,
macro@...ux-mips.org, yinghai@...nel.org,
linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] x86,mcheck: Thermal monitoring depends on APIC
being enabled
On Tue, Dec 08, 2009 at 06:53:17PM +0300, Cyrill Gorcunov wrote:
> Add check if APIC is not disabled since thermal
> monitoring depends on it. As only apic gets disabled
> we should not try to install "thermal monitor" vector,
> print out that thermal monitoring is enabled and etc...
>
> Note that "Intel Correct Machine Check Interrupts" already
> has such a check as well.
>
> Also I decided to not add cpu_has_apic check into mcheck_intel_therm_init
> since even if it'll call apic_read on disabled apic -- it's safe
> here and allow us to save a few code bytes.
>
> Reported-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> ---
>
Though the second patch is not for merging (i'm working on it) --
this one is still valid.
-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists